Repository navigation
Fix commission export dates appearing a day early - #4784
Closed
steven-tey wants to merge 1 commit into
Closed
steven-tey wants to merge 1 commit into
steven-tey wants to merge 1 commit into
Conversation
CSV date columns used toISOString(), so they were always UTC while the commissions table shows the browser timezone. Early-morning local commissions then looked like the day before the selected filter. Format createdAt, updatedAt, and paidAt in the timezone already sent with the export. Co-authored-by: Steven Tey <steven@dub.co>
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filtering commissions for Oct 8–12 showed the right rows in the table, but the CSV listed some of those same commissions as Oct 7.
createdAt,updatedAt, andpaidAtwere written withtoISOString(), which is always UTC. The table formats those timestamps in the browser timezone. A commission at Oct 8, 6:59am in China (UTC+8) was exported as2026-10-07 22:59:59.The export request already sends that timezone (it is used for the date filter). Date columns are now written as wall-clock time in that timezone, for both the immediate download and the background export. Missing or invalid timezones still fall back to UTC.
Test plan
formatCommissionsForExportconverts2026-10-07T22:59:59Zto2026-10-08 06:59:59inAsia/Shanghai2026-10-07 15:59:59inAmerica/Los_Angeles(PDT)paidAtstays blankSlack Thread